Passive Update mode supported #1014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST /vs/{VipPort}/rs
PUT /vs/{VipPort}
ywc689
added
the
pr/to-review-codes
ywc689
reviewed
Mar 4, 2025
| update = true | ||
| } | ||
|
|
||
| if vsModel != nil { |
There was a problem hiding this comment.
It's the contrary side of previous if condition. if...else... is more efficient.
| update = true | ||
| } | ||
|
|
||
| if len(vsModel.RSs.Items) == len(rss) { |
There was a problem hiding this comment.
It's the contrary side of previous if condition. if...else... is more efficient.
| h.logger.Info("Try update update. rs nat mode has changed.", "VipPort", params.VipPort, "rs", newRs.ID(), "cache nat mode", cacheRs.Spec.Mode, "update nat mode", newRs.GetFwdModeString()) | ||
| update = true | ||
| break | ||
| } |
There was a problem hiding this comment.
Doesn't it need to consider any other field changes in RS?
Comment on lines
+116
to
+119
| newFlags := vs.GetFlags() | ||
| newFlagsNOT := ^newFlags | ||
| tmpFlags := vsModel.RAMFlags ^ newFlagsNOT | ||
| if (tmpFlags & vsModel.RAMFlags) != newFlags { |
There was a problem hiding this comment.
What's purpose of the four line codes? To tell if vsModel.RAMFlags != vs.GetFlags()?
ywc689
removed
the
pr/to-review-codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will rescheduled to the header realserver while DPVS_SO_SET_ADD | DPVS_SO_SET_EDIT occurred.
The high frequent service changes may lead to backend load imbalance due to schedule resets.
POST /vs/{VipPort}/rs?passiveUpdate=true
PUT /vs/{VipPort}?passiveUpdate=true