Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define unicode in Python 3 #6

Closed
wants to merge 1 commit into from
Closed

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 9, 2019

No description provided.

@iredmail
Copy link
Owner

iredmail commented Sep 9, 2019

Dear @cclauss,

I will drop py2 support in this project and use py3 only. So no need to send PR for py2 compatibility.
Thank you very much for the contribution. :)

@iredmail iredmail closed this Sep 9, 2019
@cclauss
Copy link
Contributor Author

cclauss commented Sep 9, 2019

Here is the trick. It is better to have a single codebase that supports both Python 2 and Python 3 -- even if it only exists for a little while. It helps a lot to be able to do A/B testing. Being able to run the A client against the B server and vice versa can aid in finding bytes vs. strings incompatibilities. Enabling rollbackable transitions has proven to be useful on many Py2 to Py3 transitions. Being able to measure performance on A/B can be useful as well.

In this codebase, you only have one single redefine. I would encourage you to accept it because there is proven value in A/B testing on a single codebase and when you shift to Python 3 only, this change is isolated to a single file. Your choice of course but that is my advise after having done many Python 2 to Python 3 conversions.

@iredmail
Copy link
Owner

iredmail commented Sep 9, 2019

Thanks for sharing.

  • This is a small py program, mostly do file read/write/update and few SQL/LDAP queries/updates.
  • I will update file tools/upgrade_mlmmjadmin.sh to install py3 and required py modules during upgrade on different Linux/BSD distributions.
  • Performance is not a concern at all since no heavy access to this program.

So, no need to take care of py2 support and let's just switch to py3-only completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants