Skip to content

Commit

Permalink
Merge pull request #41 from iress/node-18
Browse files Browse the repository at this point in the history
include nodejs18.x in build targets
  • Loading branch information
SiCoe authored Sep 26, 2023
2 parents 7d0c091 + 801f50d commit 35b12be
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v2
Expand Down
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Detailed instructions on testing your function can be found [in the Wiki](https:
## Build Requirements

* [npm](https://www.npmjs.com/) ^7.20.0
* [node](https://nodejs.org/en/) ^14.0
* [node](https://nodejs.org/en/) ^18.0
* [openssl](https://www.openssl.org)

## Building Generic Packages
Expand All @@ -179,7 +179,9 @@ The supported values of `package` are:
* `okta_native` - builds a generic Lambda package for OKTA Native authentication
* `rotate_key_pair` - builds a Lambda package for rotating the RSA keys in AWS Secrets Manager

GitHub Actions automatically creates a new GitHub release when the repository owner pushes a tag that begins with `v`:
GitHub Actions automatically creates a new GitHub release when the repository owner pushes a tag that begins with `v`.

e.g.

```sh
git tag -a -m "Target AWS Lambda Node.js 14.x runtime" v3.0.0
Expand Down
2 changes: 1 addition & 1 deletion infra/terraform/modules/_lambda/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ resource "aws_lambda_function" "main" {
role = aws_iam_role.lambda.arn
handler = "index.handler"
source_code_hash = base64sha256(var.package_url)
runtime = "nodejs14.x"
runtime = "nodejs18.x"
timeout = var.timeout
publish = var.lambda_at_edge
tags = var.tags
Expand Down
2 changes: 1 addition & 1 deletion template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Resources:
Properties:
CodeUri: distributions/{distribution_name}/{distribution_name}.zip
Role: !GetAtt LambdaEdgeFunctionRole.Arn
Runtime: nodejs14.x
Runtime: nodejs18.x
Handler: index.handler
Timeout: 5
AutoPublishAlias: LIVE
Expand Down

0 comments on commit 35b12be

Please sign in to comment.