forked from Widen/cloudfront-auth
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4: Resolution of security (pen test) findings, dependancy vulnerabilities and other small updates #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include nodejs18.x in build targets
Configure NONCE and CV cookies as `secure` for pkce
All cookies sameSite as `Strict` for pkce
Set cookies as `secure` and `samesite: strict`in open github and openid
allows tooling to identify engine version
include Content-Type header in responses
Correct footers to correct repository url
This is due to licensing consern. 'html-entities' is distributed with the MIT license .
URI encode template replacement to avoid XSS
all `npm audit` vulnerability severities removed by updating referenced versions note: some are breaking change updates
steve-forth
approved these changes
Oct 2, 2023
iress-ac
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request major version bumps master to version 4.
Note: all major updates have already been reviewed to get into this v4 branch.
Changes
SameSite
cookie attribute tostrict
.Secure
cookie attribute.npm audit
vulnerability severities removed by updating referenced versions.