Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4: Resolution of security (pen test) findings, dependancy vulnerabilities and other small updates #45

Merged
merged 22 commits into from
Oct 2, 2023

Conversation

SiCoe
Copy link

@SiCoe SiCoe commented Oct 2, 2023

This pull request major version bumps master to version 4.

Note: all major updates have already been reviewed to get into this v4 branch.

Changes

  • HTML encoding template replacements to avoid potential cross-site scripting issue.
    • It was found that the _callback page utilized in the authorization flow reflects potentially dangerous user input, though there a number of caveats to this that prevented the successful execution of meaningful attacks such as XSS and HTML Injection.
  • Setting SameSite cookie attribute to strict.
    • SameSite prevents the browser from sending this cookie along with cross-site requests. The main goal is to mitigate the risk of cross-origin information leakage. It also provides some protection against cross-site request forgery attacks.
  • Setting Secure cookie attribute.
    • If the secure flag is set on a cookie, then browsers will not submit the cookie in any requests that use an unencrypted HTTP connection, thereby preventing the cookie from being trivially intercepted by an attacker monitoring network traffic. If the secure flag is not set, then the cookie will be transmitted in clear-text if the user visits any HTTP URLs within the cookie's scope. An attacker may be able to induce this event by feeding a user suitable links, either directly or via another web site.
  • Update npm dependencies to remove vulnerabilities.
    • All npm audit vulnerability severities removed by updating referenced versions.
  • Update returned footer information to reference this repository instead of upstream.
  • Include testing against nodejs v18 (current latest nodejs version for Lambda@Edge).

include nodejs18.x in build targets
Configure NONCE and CV cookies as `secure` for pkce
All cookies sameSite as `Strict` for pkce
Set cookies as `secure` and `samesite: strict`in open github and openid
allows tooling to identify engine version
include Content-Type header in responses
Correct footers to correct repository url
This is due to licensing consern. 'html-entities' is distributed with the MIT license .
URI encode template replacement to avoid XSS
all `npm audit` vulnerability severities removed by updating referenced versions

note: some are breaking change updates
@SiCoe SiCoe added this to the v4 milestone Oct 2, 2023
@SiCoe SiCoe merged commit 183bf6b into master Oct 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants