Set SameSite cookie attribute to Lax for CV and NONCE #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables authentication that isn't embeded into the same site. e.g. changing host to Okta to log in, then back to site once authenticated.
iress-ac
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change re-enables the ability to have authentication that isn't embedded into the same site.
e.g. changing host to Okta to log in, then back to site once authenticated.
The feature was removed in security bump to version 4, but is required by one of our uses of this module.
Note: this PR also sets the
SameSiteandSecurecookie attributes when removing (expiring) the cookies to the same values as when it was set to conform with browser implementations from the Incrementally Better Cookies that's now required for all values:Strict,LaxandNone.