fix: stop redirect loop caused by TOKEN cookie not sent #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the previous change works when authenticating on an external site and then browsing to the site using this module. Redirecting to the site using this module from the authentication site does not work and ends in a 302 redirect loop.
This is caused by the
TOKENcookie havingSameSiteset toStrict. The browser does not count the/callback?...302 redirect to/as the same site and therefore does not send theTOKENcookie.I've updated the
SameSitetoLaxfor theTOKENcookie so that it will be sent on the redirect.