Skip to content

Commit

Permalink
Update node & github action versions (#18)
Browse files Browse the repository at this point in the history
  • Loading branch information
franklychilled authored Feb 21, 2024
1 parent 8f43ae8 commit 7a100c3
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ updates:
schedule:
interval: daily
time: "10:00"
open-pull-requests-limit: 0 # only allow security update
open-pull-requests-limit: 50 # only allow security update
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -50,7 +50,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand Down
15 changes: 9 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,19 @@ jobs:
# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/checkout@v2
- name: install node v14
uses: actions/setup-node@v1
- uses: actions/checkout@v4
- name: install Current node version
uses: actions/setup-node@v4
with:
node-version: 14
node-version: 'current'
registry-url: ${{ secrets.NPM_REGISTRY }}
- name: npm install
run: npm ci
- name: Build
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- name: Build Typescript
run: npm run build
- name: Test
- name: Run Unit tests
run: npm run test
- name: buildkite/plugin-linter
run: make linter
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG DOCKER_CACHE
FROM ${DOCKER_CACHE}node:14-alpine
FROM ${DOCKER_CACHE}node:20-alpine

ADD . /app

Expand Down
6 changes: 5 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
version: "3"
services:
slack-notification:
image: slack-notification:build-${BUILDKITE_BUILD_NUMBER}
build:
context: .
dockerfile: Dockerfile
args:
- DOCKER_CACHE
environment:
SLACK_TOKEN: ${TOKEN_VALUE}
SLACK_CHANNEL: ${BUILDKITE_PLUGIN_JUNIT_SLACK_NOTIFICATION_SLACK_CHANNEL}
Expand Down
6 changes: 0 additions & 6 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@ IMAGE_NAME ?= slack-notification

BUILDKITE_PLUGIN_JUNIT_SLACK_NOTIFICATION_DOCKER_CACHE ?=

test: build run

build:
echo building $(IMAGE_NAME):build-${BUILDKITE_BUILD_NUMBER}
docker build --tag=$(IMAGE_NAME):build-${BUILDKITE_BUILD_NUMBER} --build-arg DOCKER_CACHE=${BUILDKITE_PLUGIN_JUNIT_SLACK_NOTIFICATION_DOCKER_CACHE} .

run:
docker-compose run --rm slack-notification

Expand Down

0 comments on commit 7a100c3

Please sign in to comment.