-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from call_id to task_id for consistency #553
base: master
Are you sure you want to change the base?
Conversation
Is this only for async functions? We named them call_id in reference to a "functions calls", not sure we should have task_id and call_id. |
@treeder the thing is that Async execution returns call_id, but I need to query |
@seiflotfy @pedronasser @treeder Guys, can we make certain decision on this one? |
So I am pretty ok with that change, we are not 1.0 and I like the changes to the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A good merge message covering on the reason and consequences of this change is a must. Regarding everything else, LGTM. |
The main thing that bugs me about this is having different names for essentially the same thing. We should choose one or the other across the board. |
@treeder isn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just trying to decouple my account from this.
As part of async execution HTTP API response IronFunctions returns
call_id
. But it's actually referring to task ID (frommodels.Task
). In order to keep consistency between tasks objects (that are available via/tasks
HTTP API) that are containingtask_id
and nocall_id
it is necessary to renamecall_id
totask_id
.This patch renames
call_id
that comes as part of API response on async execution request totask_id
for API consistency purposes.HTTP API impact:
call_id
renamed totask_id
Partially addresses: #415