Irios test nb GitHub action #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontStyles (mozilla-mobile#19815) * Update: Fonts related to Home cells to use FXFontStyles * withSize property removed according latest comment * Fix: withSize removed * Fix: obsolete UX constant removed * Fix: font according latest review --------- Co-authored-by: Nikolay Pochekuev <[email protected]>
…indows (mozilla-mobile#20147) * [8064] Fix several issues and retain cycles causing BVC, homepage, and tab manager to be retained even after closing an iPad window. * [8064] Remove weak ref, not needed in this closure * [8064] Stylistic cleanup * [8064] Minor cleanup, remove self references * [8064] Fix unit test
…r changing the wallpaper (mozilla-mobile#19950) * FXIOS-8985 mozilla-mobile#19833 ⁃ Weird display of "Customize Homepage" button after changing the wallpaper * FXIOS-8985 mozilla-mobile#19833 ⁃ Weird display of "Customize Homepage" button after changing the wallpaper Added corner radius only for the UIVisualEffectView subview, of the Customize Homepage button. * FXIOS-8985 mozilla-mobile#19833 ⁃ Weird display of "Customize Homepage" button after changing the wallpaper * FXIOS-8985 mozilla-mobile#19833 ⁃ Weird display of "Customize Homepage" button after changing the wallpaper Added few comments on the change * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Nishant Bhasin <[email protected]>
…#19946) * empty commit * Add TestRail URL. Uncomment currently working tests. * Missing one URL * remove print statement * Align tests from WebsiteAccessTests to TestRail * Move WebsiteAccessTest to SettingAppearanceTest * Remove WebsiteAccessTest.swift * Rename SettingAppearanceTest to SettingTest * Add TestRail test for testVisitWebiste
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.1.3...3.1.4) --- updated-dependencies: - dependency-name: jinja2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0504050247 (mozilla-mobile#20150) * Auto update SPM with latest rust-component release 127.0.20240504050247 * fix build errors * Update firefox-ios/Providers/Profile.swift Co-authored-by: Lina Butler <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cyndichin <[email protected]> Co-authored-by: Lina Butler <[email protected]>
…bile#20169) * Add metric where the engine is updated * Update wrapper to avoid null for engine metric
…lla-mobile#20045) * Fix MTE-2675 Workaround to run github action after automatic PR * adding slack notification when github action fails * continue on error to allow PR creation and send notification * address reviewer comments
…48 (mozilla-mobile#20166) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Bugfix MTE-2781 Homebre-core folder not found * fix spelling mistake
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…-mobile#20172) * [9050] Updates to our Throttler and related unit tests * [9050] Use throttler in window tab sync coordinator
…54 (mozilla-mobile#20188) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* 🈳 Empty commit * Rename BasicBrowsing to Browsing * Oops. Should be BrowsingTest * Enable RequestDesktopTest 🎉 * Move testActivityMenuRequestDesktopItem to BrowsingTest. Add TestRail link. * Add TestRail URL to testCheckCollapsedURL * Remove CollapsedURLTest file * Remove CollapsedURLTest file * Comment out known issue with the link
* empty commit * Add TestRail links to Page Action Menu tests * Rename FindInPageTest to PageActionMenuTest * Add smoke test comment
…la-mobile#20190) * [9049] Fix close all private tabs widget action to work with multi-window * [9049] Remove debug comment * [9049] Typo fix * [9049] Some updates to fix existing unit test and also allow for more future testing options of WindowManager * [9049] Fix mock wrapper method * [9049] Cleanup
…ozilla-mobile#20158) * * Added `browserviewcontroller.adjustURLBarHeightBasedOnLocationViewHeight()` function to dynamically change `urlBar` height to the text size selected by user in iOS accessbility settings. * Function will also add a spacer to the bottom of `overKeyboardContainer` to keep the app switcher bar from overlapping or touching the url text field when toolbar is set to bottom of the screen and when in landscape mode and when keyboard is not showing. * Added `BaseContentStackView.addBottomInsetSpacer()` and `BaseContentStackView.removeBottomInsetSpacer` methods so a spacer can be added and removed from `overKeyboardContainer`. * Added `browserviewcontroller.keyboardHelper(keyboardDidShowWithState)` delegate to move `overKeyboardContainer` into the correct position when `browserviewcontroller.keyboardHelper(keyboardWillShowWithState)` gets the incorrect view position from iOS. The bug causes `browswerviewcontroller.keyboardState.intersectionHeightForView()` to return a keyboard height that is incorrect which in turn causes `overKeyboardContainer` to be placed in the wrong position. This results in the keyboard overlapping the url text field. Bug happens randomly and infrequently when adding a new tab. `browserviewcontroller.keyboardHelper(keyboardDidShowWithState)` acts as a backstop in case this bug happens. * Added `UIConstants.ToolbarPadding` to keep the highlighted URL text field from touching the bottom of `urlBar`. * Oops, forgot to uncomment the code.
…le#20161) * [8973] Inject tab data stores instead of using a shared ubiquitous instance, this fixes some problems that could occur when multiple windows would attempt to save their tabs at the same time, because the tab data store is not fundamentally thread safe for this scenario * [8973] Remove tab data store from shared app container * [8973] Minor cleanup, refactor * [8973] Minor cleanup * [8973] Minor cleanup * [8973] Fix window manager unit tests * [8973] Unit test fix * [8973] Remove tab data store mock from dependency helper in unit tests also
* 🈳 Empty commit * Remove WebsiteMemoryTest completely
* 🈳 Empty commit * Add TestRail link
…50 (mozilla-mobile#20193) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…obile#20196) * Remove references to RequestDesktopTest * empty commit
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ile#20140) * Add tablet icon * Use new device icon and make code cleaner * Update flash icons * Rename image to match Acorn * Update icon * Fix file name spelling * Merge asset catalogs * Update tabs icon * Combine asset catalogs * Remove extensions for AutocompleteTextField * Update subtract icon * Update sponsored star icon * Update url bar clear button icon * Add iconRatingNeutral * Update Fakespot star icons * Fix warning * Update tab icon * Update private mode badge icon * Update clear image for credential provider * Update cloud image and colors * Update sun icons in reader mode * Move shopping icon out of folder * Fix file spelling * Address PR comment * Fix Swiftlint * Remove import * Re-add import * Remove MockWindowManager from Client * Update UI test to use new tab image
) * Add feature flag for toolbar refactor * Add toolbar reducer, middleware, etc * Add ToolbarKit to project * Fix address toolbar background color * Set height for address toolbar * Update comment * Add browserDidLoad action which triggers toolbar middleware * Add navigation toolbar to browser vc * Add action type * Adjust redux actions after merge * Rename action * Add toolbar action for home button * Fix build * Turn feature off * Fix endless loop of Fakespot actions being dispatched * Fix spelling * Remove public for UX properties * Remove capturing self * Optimize code * Fix Swiftlint error
…zilla-mobile#20191) * Add isSelectedOnTap bool property into the model * Add shouldDisplayAsHighlighted property to ToolbarButton class * Fix Swiftlint * Fix Swiftlint 2
…nside image (mozilla-mobile#20184) * Create TabNumberButton class * Add condition to check the type of Toolbar Button * Fix Swiftlint errors * Use FXFontStyles for font, change name of maxTabCountToShowInfinity and logic * Update tab icon
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…d rules fixed file location minor changes to the makedirs portion minor file name change Added missing slack payload file and updated script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)