Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] Fix torch furthest_point_sampling argument typo #7025

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BeingGod
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

To fix pytorch furthest_point_sampling argument typo.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • [ x For fork PRs, I have selected Allow edits from maintainers.

Description

To fix pytorch furthest_point_sampling argument typo. Rename from sample_siz to sample_size.

Copy link

update-docs bot commented Oct 24, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@BeingGod
Copy link
Contributor Author

@ssheorey Can you help me review this PR ?

@ssheorey ssheorey requested a review from benjaminum November 17, 2024 07:15
@BeingGod
Copy link
Contributor Author

BeingGod commented Dec 9, 2024

Can you help me merge this PR ? @ssheorey

@ssheorey
Copy link
Member

@benjaminum does this affect the API?

@benjaminum
Copy link
Contributor

@benjaminum does this affect the API?

I will check

@benjaminum
Copy link
Contributor

@ssheorey Yes it does change the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants