-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace experimental uninstall command with uninstall command #11736
Conversation
content/en/docs/tasks/security/authorization/authz-td-migration/index.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/observability/distributed-tracing/opencensusagent/test.sh
Outdated
Show resolved
Hide resolved
@@ -176,7 +176,7 @@ as the old trust domain without you having to include the aliases. | |||
$ kubectl delete authorizationpolicy service-httpbin.default.svc.cluster.local | |||
$ kubectl delete deploy httpbin; kubectl delete service httpbin; kubectl delete serviceaccount httpbin | |||
$ kubectl delete deploy sleep; kubectl delete service sleep; kubectl delete serviceaccount sleep | |||
$ istioctl x uninstall --purge | |||
$ stioctl uninstall --purge -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want istioctl, not stioctl
@@ -138,7 +138,7 @@ snip_clean_up_1() { | |||
kubectl delete authorizationpolicy service-httpbin.default.svc.cluster.local | |||
kubectl delete deploy httpbin; kubectl delete service httpbin; kubectl delete serviceaccount httpbin | |||
kubectl delete deploy sleep; kubectl delete service sleep; kubectl delete serviceaccount sleep | |||
istioctl x uninstall --purge | |||
stioctl uninstall --purge -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misspelled here as well.
Signed-off-by: Tong Li <[email protected]>
Replace experimental uninstall command with uninstall command Co-authored-by: Frank Budinsky <[email protected]>
Replace experimental uninstall command with uninstall command Co-authored-by: Frank Budinsky <[email protected]>
Signed-off-by: Tong Li <[email protected]>
Signed-off-by: Tong Li <[email protected]>
Signed-off-by: Tong Li <[email protected]>
6274793
to
6791544
Compare
Signed-off-by: Tong Li <[email protected]>
A couple comments.
|
@ericvn yeah, I noticed that as well. That was the inconsistency in our docs. For document, I would prefer For the pipe y thing, to be honest with you, I never liked use pipe to send a y to the command, in my view, that is really a hack, I would like to change it all to -y especially in the test scripts which no one sees, but Frank and I had a long discussion about this, where he won the argument, so that is what we had. but I can go with either. |
content/en/docs/tasks/traffic-management/egress/wildcard-egress-hosts/index.md
Outdated
Show resolved
Hide resolved
I think you misunderstood my point. See here for clarification. |
I agree that users will want to use the short form |
…s-hosts/index.md Co-authored-by: Frank Budinsky <[email protected]>
Signed-off-by: Tong Li <[email protected]>
Signed-off-by: Tong Li [email protected]
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.