Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for installations with mTLS auth enabled #1503

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Update for installations with mTLS auth enabled #1503

merged 3 commits into from
Jun 14, 2018

Conversation

kenthua
Copy link
Contributor

@kenthua kenthua commented Jun 12, 2018

The docs do not provide reference to installations with mTLS auth enabled. If mTLS auth is enabled and the user goes through the instructions, they will encounter upstream connect error or disconnect/reset before headers when the DestinationRule is applied.

istio/old_issues_repo#375 (comment) helped lead to the resolution.

The docs do not provide reference to installations with mTLS auth enabled.  If mTLS auth is enabled and the user goes through the instructions, they will encounter `upstream connect error or disconnect/reset before headers` when the DestinationRule is applied.

istio/old_issues_repo#375 (comment) helped lead to the resolution.
@istio-testing
Copy link
Contributor

Hi @kenthua. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@geeknoid
Copy link
Contributor

geeknoid commented Jun 12, 2018

Deploy preview for preliminary-istio failed.

Built with commit 7b564b0

https://app.netlify.com/sites/preliminary-istio/deploys/5b202423b312740eb058da8f

@geeknoid
Copy link
Contributor

/lgtm

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid, kenthua

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kenthua
Copy link
Contributor Author

kenthua commented Jun 12, 2018

I'm using the same URI's as noted in the mirroring doc and other docs. But the netlify keeps failing.

12:56:12 PM: - ./public/docs/tasks/traffic-management/mirroring/index.html
12:56:12 PM:   *  linking to /docs/reference/config/istio.networking.v1alpha3/#TLSSettings.TLSmode, but TLSSettings.TLSmode does not exist (line 104)
12:56:12 PM:      <a href="/docs/reference/config/istio.networking.v1alpha3/#TLSSettings.TLSmode">TLSSettings.TLSmode</a>
12:56:12 PM: htmlproofer 3.9.1 | Error:  HTML-Proofer found 1 failure!
12:56:12 PM: make: *** [lint] Error 1

@geeknoid geeknoid requested a review from diemtvu June 13, 2018 15:07
@geeknoid
Copy link
Contributor

If you sync your tree, you will see that these URLs have been updated recently. The right path is now:

/docs/reference/config/istio.networking.v1alpha3/#TLSSettings-TLSmode

@istio-testing
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@geeknoid geeknoid merged commit 7874083 into istio:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants