feat: Copy B2 CLI URL #17108
Open
feat: Copy B2 CLI URL #17108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Adds the abiliy to copy CLI URLs to both files and directories |
dkocher
requested changes
May 19, 2025
| else { | ||
| String key; | ||
| if(file.isDirectory()) { | ||
| key = PathRelativizer.relativize(container.getAbsolute(), file.getAbsolute()); |
There was a problem hiding this comment.
Use B2PathContainerService#getKey and strip the end .bzEmpty (B2PathContainerService.PLACEHOLDER)
| URIEncoder.encode(containerService.getKey(file))); | ||
| list.add(new DescriptiveUrl(download, DescriptiveUrl.Type.http, | ||
| MessageFormat.format(LocaleFactory.localizedString("{0} URL"), Scheme.https.name().toUpperCase(Locale.ROOT)))); | ||
| if(file.isFile() || file.isDirectory()) { |
There was a problem hiding this comment.
Move check for file type inside scope of handled types.
| private final B2Session session; | ||
|
|
||
| public B2UrlProvider(final B2Session session) { | ||
| this.session = session; | ||
| this.containerService = session.getFeature(PathContainerService.class); |
There was a problem hiding this comment.
Revert this change as the pattern instantiating B2PathContainerService is present in all other features.
| if(types.contains(DescriptiveUrl.Type.provider)) { | ||
| final Path container = containerService.getContainer(file); | ||
| if(!file.isRoot()) { | ||
| String cliUrl; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17107
tests are missing