Skip to content

Release 1.2.1 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: [ '8.1' ]
php-versions: [ '8.3' ]
dependency-version: [ prefer-lowest, prefer-stable ]
steps:
- uses: actions/checkout@master
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: [ '8.1' ]
php-versions: [ '8.3' ]
dependency-version: [ prefer-lowest, prefer-stable ]
steps:
- uses: actions/checkout@master
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: [ '8.1' ]
php-versions: [ '8.3' ]
dependency-version: [ prefer-lowest, prefer-stable ]
steps:
- uses: actions/checkout@master
Expand All @@ -113,7 +113,7 @@ jobs:
run: |
# We need a Drupal project to run drupal-check (cf. https://github.com/mglaman/drupal-check#usage)
# Install Drupal
composer --no-interaction create-project drupal/recommended-project:^9 --stability=dev drupal
composer --no-interaction create-project drupal/recommended-project:^10 --stability=dev drupal
# Copy our module source code into the Drupal module folder.
mkdir -p drupal/web/modules/contrib/os2forms_sync
cp -r os2forms_sync.* composer.json src drupal/web/modules/contrib/os2forms_sync
Expand Down
10 changes: 9 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@ Versioning](https://semver.org/spec/v2.0.0.html).

### Updated

## [1.2.1]

- Update GitHub workflows runner images
- D10 compatibility - updating RequestStack

## [1.2.0]

- Drupal 10 compatibility

## [1.1.3]

### Updated
Expand Down Expand Up @@ -44,7 +50,9 @@ Versioning](https://semver.org/spec/v2.0.0.html).

- Added OS2Forms sync module

[Unreleased]: https://github.com/itk-dev/os2forms_sync/compare/1.1.3...HEAD
[Unreleased]: https://github.com/itk-dev/os2forms_sync/compare/1.2.1...HEAD
[1.2.1]: https://github.com/itk-dev/os2forms_sync/compare/1.2.0...1.2.1
[1.2.0]: https://github.com/itk-dev/os2forms_sync/compare/1.1.3...1.2.0
[1.1.3]: https://github.com/itk-dev/os2forms_sync/compare/1.1.2...1.1.3
[1.1.2]: https://github.com/itk-dev/os2forms_sync/compare/1.1.1...1.1.2
[1.1.1]: https://github.com/itk-dev/os2forms_sync/compare/1.1.0...1.1.1
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ drush os2forms-sync:import --help
## Coding standards

```sh
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer install
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer coding-standards-check
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer install
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer coding-standards-check

docker run --rm --interactive --tty --volume ${PWD}:/app node:18 yarn --cwd /app install
docker run --rm --interactive --tty --volume ${PWD}:/app node:18 yarn --cwd /app coding-standards-check
docker run --rm --interactive --tty --volume ${PWD}:/app node:20 yarn --cwd /app install
docker run --rm --interactive --tty --volume ${PWD}:/app node:20 yarn --cwd /app coding-standards-check
```

## Code analysis

```sh
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer install
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.1-fpm:latest composer code-analysis
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer install
docker run --rm --interactive --tty --volume ${PWD}:/app itkdev/php8.3-fpm:latest composer code-analysis
```
4 changes: 2 additions & 2 deletions src/Controller/WebformController.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function index(): array {
$form = $this->webformHelper->getSubmissionForm($attributes['elements']);
// Make sure that the form cannot be submitted (hopefully).
$form['#attributes']['onsubmit'] = 'return false';
$renderedForm = $this->renderer->renderPlain($form);
$renderedForm = $this->renderer->renderInIsolation($form);
}
catch (\Throwable $t) {
$form = [
Expand All @@ -137,7 +137,7 @@ public function index(): array {
],
],
];
$renderedForm = $this->renderer->renderPlain($form);
$renderedForm = $this->renderer->renderInIsolation($form);
}

$sourceUrl = $webform->sourceUrl;
Expand Down
Loading