Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for proxy checker socks4 and socks5 #37

Merged
merged 3 commits into from
Apr 25, 2024
Merged

add support for proxy checker socks4 and socks5 #37

merged 3 commits into from
Apr 25, 2024

Conversation

FosterG4
Copy link
Contributor

add support for proxy checker socks4 and socks5

@iw4p
Copy link
Owner

iw4p commented Apr 23, 2024

Hi! thank you for your contribution! Can you please run flake8 . to make sure there's no error to fix the checks?

@FosterG4
Copy link
Contributor Author

FosterG4 commented Apr 23, 2024 •
edited
Loading

Hi! thank you for your contribution! Can you please run flake8 . to make sure there's no error to fix the checks?

I have running flake8.exe . and flake8.exe --count .
do I have to re-push?

@iw4p
Copy link
Owner

iw4p commented Apr 23, 2024 via email

@FosterG4
Copy link
Contributor Author

Can you see the failed checks to make sure? Sent from Proton Mail for iOS
…
On Tue, Apr 23, 2024 at 1:50 PM, Dikky Hardian @.(mailto:On Tue, Apr 23, 2024 at 1:50 PM, Dikky Hardian < wrote: > Hi! thank you for your contribution! Can you please run flake8 . to make sure there's no error to fix the checks? I have flake8.exe running. and flake8.exe --count . do I have to re-push? — Reply to this email directly, [view it on GitHub](#37 (comment)), or unsubscribe. You are receiving this because you commented.Message ID: @.>

this is strange I tried running flake8 on my local and there's no error but on github there is
image

@iw4p
Copy link
Owner

iw4p commented Apr 23, 2024 via email

@FosterG4
Copy link
Contributor Author

FosterG4 commented Apr 25, 2024 •
edited
Loading

Are you using this configuration exactly? https://github.com/iw4p/proxy-scraper/blob/master/.flake8 Sent from Proton Mail for iOS
…
On Tue, Apr 23, 2024 at 2:29 PM, Dikky Hardian @.(mailto:On Tue, Apr 23, 2024 at 2:29 PM, Dikky Hardian < wrote: > Can you see the failed checks to make sure? Sent from Proton Mail for iOS > … > On Tue, Apr 23, 2024 at 1:50 PM, Dikky Hardian @.(mailto:On Tue, Apr 23, 2024 at 1:50 PM, Dikky Hardian <[wrote: > Hi! thank you for your contribution! Can you please run flake8 . to make sure there's no error to fix the checks? I have flake8.exe running. and flake8.exe --count . do I have to re-push? — Reply to this email directly, view it on GitHub[#37 (comment)](#37 (comment))), or unsubscribe. You are receiving this because you commented.Message ID: @.> this is strange I tried running flake8 on my local and there's no error but on github there is image.png (view on web) — Reply to this email directly, [view it on GitHub](#37 (comment)), or unsubscribe. You are receiving this because you commented.Message ID: @.>

found it i need run isort.exe .\proxyChecker.py
image

@iw4p iw4p self-requested a review April 25, 2024 07:44
@iw4p iw4p merged commit 44df425 into iw4p:master Apr 25, 2024
7 checks passed
@iw4p
Copy link
Owner

iw4p commented Apr 25, 2024

Yay 🥳 merged. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iw4p iw4p iw4p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FosterG4 @iw4p