Incorporate PR feedback.

j4james · Jan 10, 2024 · 62aa579 · 62aa579
1 parent c3a6bad
commit 62aa579
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/terminal/adapter/adaptDispatch.cpp b/src/terminal/adapter/adaptDispatch.cpp
@@ -2802,7 +2802,8 @@ void AdaptDispatch::_ClearAllTabStops() noexcept
 // - True if handled successfully. False otherwise.
 bool AdaptDispatch::TabSet(const VTParameter setType) noexcept
 {
-    if (setType == DispatchTypes::TabSetType::SetEvery8Columns || !setType.has_value())
+    constexpr auto SetEvery8Columns = DispatchTypes::TabSetType::SetEvery8Columns;
+    if (setType.value_or(SetEvery8Columns) == SetEvery8Columns)
     {
         _tabStopColumns.clear();
         _initDefaultTabStops = true;

diff --git a/src/terminal/adapter/adaptDispatch.hpp b/src/terminal/adapter/adaptDispatch.hpp
@@ -271,7 +271,7 @@ namespace Microsoft::Console::VirtualTerminal
         StringHandler _CreateDrcsPassthroughHandler(const DispatchTypes::DrcsCharsetSize charsetSize);
         StringHandler _CreatePassthroughHandler();
 
-        std::vector<bool> _tabStopColumns;
+        std::vector<uint8_t> _tabStopColumns;
         bool _initDefaultTabStops = true;
 
         ITerminalApi& _api;