Overload unimplemented getCharContent method

[onizucraft]

It seems that to be able to integrate with JavaPoet code generation tool this little tweak is needed.

[onizucraft]

Probably the encoding can be obtained somewhere else.

[ghost]

Btw, Charset.forName("UTF-8") can be replaced with StandardCharsets.UTF_8.

[lukaseder]

@since 1.7

We still support Java 6

[lukaseder]

... not in that class, though. So yes, it could be replaced. Will do

[lukaseder]

What problem is this solving? Can you please add a description and/or a test case that would fail if you hadn't added this method?

[onizucraft]

It solves issue 81, the second problem that was reported: #81 (comment)

[onizucraft]

I'll try to setup a unit test.

[onizucraft]

It may be a problem with the integration with https://github.com/square/javapoet when using it to generate code in the Processor. It seems that when writing the source code, it delegates the creation of the JavaFileObject to the filer (https://github.com/square/javapoet/blob/44622704248975ca398b90b4385005fdddeb35f9/src/main/java/com/squareup/javapoet/JavaFile.java#L164).

Im not really sure how the internals are working, but it seems that the generated file is being handled by

jOOR/jOOR-java-8/src/main/java/org/joor/Compile.java

Line 211 in 1e6b04b

public JavaFileObject getJavaFileForOutput(

I'm not sure if you want to maintain the integration with javapoet (I think it would be cool, plus it only needs this harmless tweak). I'm willing to add a unit test, but I'll have to add the javapoet dependency.

[ghost]

@GabrielPS
I don't think there is a problem with JavaPoet. Filer is a standard and preferable way for reading and writing files in the Annotation Processor.

[ghost]

@GabrielPS
Btw, you made a change in the "jOOR-java-8" module, but what about "jOOR" (for Java 9+, if I understand correctly)?
@lukaseder
Do you use some kind of generation tool and only support Java 9 implementation with tags ([java-8], [java-9], ...) or how does it all work?

[onizucraft]

I did not try other Java versions, sorry.

[lukaseder]

@GabrielPS
I don't think there is a problem with JavaPoet. Filer is a standard and preferable way for reading and writing files in the Annotation Processor.

Is there a simple way to call this method in a unit test without any third party assumptions? I think the suggested code is fine as it is, but I prefer not to accept any PRs without understanding what specific problem is being fixed.

Do you use some kind of generation tool and only support Java 9 implementation with tags ([java-8], [java-9], ...) or how does it all work?

Yes, there's a closed source preprocessor for these things.

I did not try other Java versions, sorry.

Don't worry about it. I'll take it from here, once I can see what problem this is solving.

[lukaseder]

Is this it? #98, https://github.com/jbreathe/joor-repro

[lukaseder]

I'll merge it without a test for now. If you can think of a test, feel free...

[onizucraft]

I tried to setup a test, but had no time. Sorry :(

[lukaseder]

No worries, thanks again.

[ghost]

@lukaseder

Is this it? #98, https://github.com/jbreathe/joor-repro

Yes, thank you!
I will close #98 in a minute.

Is there a simple way to call this method in a unit test without any third party assumptions?

I think yes. Give me a few minutes, I will try to change the code in my repro.

upd: something like this:

String rawSource = javaFile.toString();
try {
    javaFile.writeTo(processingEnv.getFiler());
    JavaFileObject implSourceFile = processingEnv.getFiler().createSourceFile(packageName + "." + implName);
    try (Writer writer = implSourceFile.openWriter()) {
        writer.append(rawSource);
    }
} catch (IOException e) {
    ...
}