update registeredSlots with targeting values and refresh (#226)

jaanauati · Jul 4, 2021 · ade4f3b · ade4f3b
1 parent a5c3392
commit ade4f3b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/js/manager.js b/js/manager.js
@@ -104,6 +104,10 @@ const DFPManager = Object.assign(new EventEmitter().setMaxListeners(0), {
 
   setTargetingArguments(data) {
     Object.assign(globalTargetingArguments, data);
+    const availableKeys = Object.keys(registeredSlots);
+    availableKeys.forEach((slotId) => {
+      registeredSlots[slotId].targetingArguments = data;
+    });
     if (managerAlreadyInitialized === true) {
       this.getGoogletag().then((googletag) => {
         googletag.cmd.push(() => {
@@ -354,9 +358,8 @@ const DFPManager = Object.assign(new EventEmitter().setMaxListeners(0), {
       this.configureOptions(googletag);
       googletag.cmd.push(() => {
         const pubadsService = googletag.pubads();
-        pubadsService.refresh(
-          slots.map(slotId => registeredSlots[slotId].gptSlot),
-        );
+        const slotsToRefreshArray = slots.map(slotId => registeredSlots[slotId].slotId);
+        pubadsService.refresh(slotsToRefreshArray);
       });
     });
   },

diff --git a/lib/manager.js b/lib/manager.js
@@ -104,6 +104,10 @@ var DFPManager = Object.assign(new _events.EventEmitter().setMaxListeners(0), {
   },
   setTargetingArguments: function setTargetingArguments(data) {
     Object.assign(globalTargetingArguments, data);
+    var availableKeys = Object.keys(registeredSlots);
+    availableKeys.forEach(function (slotId) {
+      registeredSlots[slotId].targetingArguments = data;
+    });
 
     if (managerAlreadyInitialized === true) {
       this.getGoogletag().then(function (googletag) {
@@ -398,9 +402,10 @@ var DFPManager = Object.assign(new _events.EventEmitter().setMaxListeners(0), {
 
       googletag.cmd.push(function () {
         var pubadsService = googletag.pubads();
-        pubadsService.refresh(slots.map(function (slotId) {
-          return registeredSlots[slotId].gptSlot;
-        }));
+        var slotsToRefreshArray = slots.map(function (slotId) {
+          return registeredSlots[slotId].slotId;
+        });
+        pubadsService.refresh(slotsToRefreshArray);
       });
     });
   },