Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Import Image from Gallery on Android #51

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

vicajilau
Copy link
Collaborator

No description provided.

Copy link

@CodeRedDev CodeRedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional part looks good 👍

README has some errors.

  1. Part of the description of noOfPages slipped under the description for isGalleryImportAllowed
  2. noOfPages also only works on Android. The parameter is never used in the iOS implementation.

Copy link

@CodeRedDev CodeRedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest a version that increases the readability:

How to use ?

The easiest way to get a list of images is:

    final imagesPath = await CunningDocumentScanner.getPictures()

Android Specific

final imagesPath = await CunningDocumentScanner.getPictures(
    noOfPages: 1, // Limit the number of pages to 1
    isGalleryImportAllowed, // Allow the user to also pick an image from his gallery
)

Copy link

@CodeRedDev CodeRedDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jachzen jachzen merged commit 4697cb5 into master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants