Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iOS WeScan support and add more Android options #62

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

romainboucher
Copy link

@romainboucher romainboucher commented Apr 17, 2024

For iOS :

  • Allow multiple pages
  • Text localizations : English, French, ...
  • Update Readme
  • Customize colors : background and tint
  • Customize options : Automode, flash, gallery

For Android :

  • Customize ScannerMode (allow filter, base or full mode)
  • Allow / disallow auto mode

@romainboucher
Copy link
Author

@jachzen can you check this PR this please ? 😃

@romainboucher romainboucher marked this pull request as draft April 18, 2024 08:07
@romainboucher romainboucher changed the title feat: add android scanner mode option feat: add iOS WeScan support and add more Android options Apr 18, 2024
@romainboucher
Copy link
Author

romainboucher commented Apr 18, 2024

#16
#57
#61

@romainboucher
Copy link
Author

@jachzen jachzen marked this pull request as ready for review April 20, 2024 11:24
@jachzen
Copy link
Owner

jachzen commented Apr 20, 2024

@romainboucher thanks a lot for your work. i also started with wescan but couldn't find time to make progress. so thanks a lot for contributing. i will merge it in master. but i think the unittests are failing for now. maybe you can fix them.

@jachzen
Copy link
Owner

jachzen commented Apr 20, 2024

and i think it must be possible to add more than one image.

@jachzen jachzen requested a review from vicajilau April 21, 2024 09:37
@romainboucher
Copy link
Author

and i think it must be possible to add more than one image.

ok, I'll add that in a few days.

@elmargro
Copy link

@romainboucher are you still on it?

@jachzen
Copy link
Owner

jachzen commented May 13, 2024

and i think it must be possible to add more than one image.

ok, I'll add that in a few days.

Hi Roman. Are still working on this ticket. otherwise i will finish it.

@romainboucher
Copy link
Author

sorry @jachzen, I don't have time at the moment. I think in a few weeks.

@ptantai
Copy link

ptantai commented Aug 8, 2024

Hi @jachzen Do you have time to finish this, i think Roman is quite busy with his own work. Thanks @jachzen !

@saileshbro
Copy link

hi @romainboucher, is there any way we can pass the file path of the image in memory and open the cropper only without letting user click image/select from gallery?

@lucasdidur
Copy link

@romainboucher Any updates on this?

@MbeleLebohang-uct
Copy link

Upvoting the importance of this PR.

1 similar comment
@abed-supy-io
Copy link

Upvoting the importance of this PR.

@abed-supy-io
Copy link

@romainboucher When are you expecting to finalize this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants