Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use Spring bootBuildImage #332

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

jnodorp-jaconi
Copy link
Member

@jnodorp-jaconi jnodorp-jaconi commented Jan 13, 2025

Pull request checklist

Pull request structure

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Check the commits message styles matches our requested structure.

Implementation checks

  • Tests for the changes have been added.
  • Docs have been reviewed and added / updated if needed.
  • Tests (gradle clean check) have passed locally any fixes were made for failures.
  • GitHub checks all pass (GH Actions, Sonar, Codecov).

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL:

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

This PR will break ARM images if merged as is. We should revisit this PR once ARM based GitHub runners are GA.

Other information


❤️ Thank you!

@jnodorp-jaconi jnodorp-jaconi changed the title build: use Spring buildBootImage build: use Spring bootBootImage Jan 13, 2025
@jnodorp-jaconi jnodorp-jaconi changed the title build: use Spring bootBootImage build: use Spring bootBuildImage Jan 13, 2025
@jnodorp-jaconi jnodorp-jaconi marked this pull request as draft January 13, 2025 13:26
@jnodorp-jaconi jnodorp-jaconi mentioned this pull request Jan 13, 2025
16 tasks
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (9e56419) to head (aae9e2e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #332   +/-   ##
=========================================
  Coverage     87.45%   87.45%           
  Complexity      111      111           
=========================================
  Files            27       27           
  Lines           287      287           
  Branches         29       29           
=========================================
  Hits            251      251           
  Misses           22       22           
  Partials         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants