Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger] Allow overriding image registry at the global level #542

Merged
merged 1 commit into from
Mar 14, 2024
Merged

[jaeger] Allow overriding image registry at the global level #542

merged 1 commit into from
Mar 14, 2024

Conversation

bens545
Copy link
Contributor

@bens545 bens545 commented Mar 9, 2024 •
edited
Loading

What this PR does

  • Splits image registry, repository, and tag. Allowing for overriding of any one without affecting the other
  • Allow overriding the image registry in the global config
  • Allow setting the pullSecrets at the global level

Which issue this PR fixes

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

@bens545 bens545 force-pushed the registry-override branch 4 times, most recently from 505ed32 to 49b3f9f Compare March 10, 2024 04:20
@bens545 bens545 marked this pull request as ready for review March 10, 2024 04:20
@bens545 bens545 force-pushed the registry-override branch from 49b3f9f to 0504a35 Compare March 12, 2024 03:23
@bens545 bens545 requested a review from pavelnikolov March 12, 2024 03:24
@Stevenpc3
Copy link
Contributor

👍

@bens545 bens545 force-pushed the registry-override branch from 0504a35 to d97c746 Compare March 14, 2024 02:37
@bens545
Copy link
Contributor Author

bens545 commented Mar 14, 2024

I removed the registry to bring it in line with what was previously there. (Instead of making it registry.hub.docker.com). It should be able to pull the images now.

@pavelnikolov pavelnikolov merged commit 94cb97a into jaegertracing:main Mar 14, 2024
2 checks passed
@bens545 bens545 mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidvonthenen davidvonthenen Awaiting requested review from davidvonthenen

@naseemkullah naseemkullah Awaiting requested review from naseemkullah naseemkullah is a code owner

@pavelnikolov pavelnikolov Awaiting requested review from pavelnikolov pavelnikolov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bens545 @Stevenpc3 @pavelnikolov