Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme for Z algorithm #2594

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Readme for Z algorithm #2594

merged 1 commit into from
Apr 15, 2020

Conversation

syedareehaquasar
Copy link
Contributor

@syedareehaquasar syedareehaquasar commented Mar 22, 2020 •
edited
Loading

Fixes #2478

Changes proposed in this pull request:

Files Added:

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

@syedareehaquasar
Copy link
Contributor Author

plese review @jainaman224

asha15
asha15 requested changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@asha15 asha15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your file should contain the following:

Explanation
Algorithm
Pseudocode
Example
Time Complexity

Also add images/GIFs to explain if possible.

Ford_Fulkerson_Method/README.md Outdated Show resolved Hide resolved
Ford_Fulkerson_Method/README.md Outdated Show resolved Hide resolved
Ford_Fulkerson_Method/README.md Outdated Show resolved Hide resolved
Ford_Fulkerson_Method/README.md Outdated Show resolved Hide resolved
Ford_Fulkerson_Method/README.md Outdated Show resolved Hide resolved
@syedareehaquasar
Copy link
Contributor Author

@asha15 please review updated readme ... all necessary changes done

@syedareehaquasar
Copy link
Contributor Author

@asha15 please review updated readme ... all necessary changes done

asha15
asha15 requested changes Apr 2, 2020
View reviewed changes
Copy link
Collaborator

@asha15 asha15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still you didn't provide the pseudo code and an example

please include it

Z_Algorithm/README.md Outdated Show resolved Hide resolved
Z_Algorithm/README.md Outdated Show resolved Hide resolved
Ford_Fulkerson_Method/README.md Outdated Show resolved Hide resolved
Z_Algorithm/README.md Outdated Show resolved Hide resolved
Z_Algorithm/README.md Outdated Show resolved Hide resolved
Z_Algorithm/README.md Outdated Show resolved Hide resolved
@syedareehaquasar
Copy link
Contributor Author

@asha15 please review

asha15
asha15 requested changes Apr 6, 2020
View reviewed changes
Z_Algorithm/README.md Outdated Show resolved Hide resolved
asha15
asha15 requested changes Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@asha15 asha15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits and push it

Z_Algorithm/README.md Outdated Show resolved Hide resolved
Z_Algorithm/README.md Outdated Show resolved Hide resolved
@syedareehaquasar
Copy link
Contributor Author

@asha15 please check done squash too

@syedareehaquasar
Copy link
Contributor Author

please review @asha15

@asha15 asha15 merged commit 3188f22 into jainaman224:master Apr 15, 2020
Amitsharma45 pushed a commit to Amitsharma45/Algo_Ds_Notes that referenced this pull request May 31, 2020
@syedareehaquasar @Amitsharma45
README.md for Z-ALGORITHM (jainaman224#2594)
257611d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asha15 asha15 asha15 approved these changes

Assignees
No one assigned
Labels
easy GSSoC20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Z algorithm
2 participants
@syedareehaquasar @asha15