Adding PHP implementation for LIS (Issue #2253) #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raghav-dalmia @SakshiShreya @AdityaShD Kindly review my PR. |
asha15
requested changes
Apr 10, 2020
| @@ -0,0 +1,44 @@ | |||
| <?php | |||
| // PHP Implementation of LIS using Dynamic Programming | |||
There was a problem hiding this comment.
Put this commend at the beginning of the file
|
|
||
| // fumction to return the length of LIS | ||
| function lisLen($arr, $n){ | ||
| // $dp[$i] represents length of LIS ending at index i |
There was a problem hiding this comment.
Made the second required change in the PR. Left the first one as discussed with you @asha15
Kindly review it.
Update LIS.php
asha15
approved these changes
Apr 15, 2020
|
Since, it has been approved, kindly merge it @asha15 @jainaman224 |
Amitsharma45
pushed a commit
to Amitsharma45/Algo_Ds_Notes
that referenced
this pull request
May 31, 2020
Update LIS.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2253
Checklist:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Changes proposed in this pull request:
Languages Used:
Files Added:
Thanks!