Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree_Preorder_Traversal.js Added #2756

Closed
wants to merge 54 commits into from
Closed

Tree_Preorder_Traversal.js Added #2756

wants to merge 54 commits into from

Conversation

afroz23
Copy link
Contributor

@afroz23 afroz23 commented Apr 14, 2020 •
edited
Loading

Fixes #2550

Checklist:

  • 4 space indentation.
  • Coding conventions are followed.
  • Input is taken dynamically.
  • Sample Input / Output is added at the end of file.
  • Logic Documentation (Comments).
  • File names are correct.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

Changes proposed in this pull request:

  • Tree_Preorder_Traversal.js Added

Languages Used:

  • JavaScript

Files Added:

  • Tree_Preorder_Traversal.js

We're happy to help you get this ready -- don't be afraid to ask for help.

Thanks!

@afroz23
Copy link
Contributor Author

afroz23 commented Apr 20, 2020

@singh-shreya6 mam review it :)

singh-shreya6
singh-shreya6 previously approved these changes Apr 24, 2020
View reviewed changes
@singh-shreya6
Copy link
Collaborator

Squash your commits @afroz23. The code looks good.

afroz23 and others added 9 commits April 25, 2020 12:18
@afroz23
commit 3
a4c623f
@VIJAY07102 @afroz23
Priority_Queue.py
48249ad 
Priority_Queue
@abhushanaj @afroz23
Added implementation of Z-Algorithm in JS (jainaman224#2607)
bad4dc1
@himanshusharma89 @afroz23
Created Pancake Sort in C# (jainaman224#2309)
412de13 
* Create Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs

* Update Pancake_Sort.cs
@PrachieNaik @afroz23
Create Tree_Preorder_Traversal.kt (jainaman224#2585)
8a48be5 
* Create Tree_Preorder_Traversal.kt

* Update Tree_Preorder_Traversal.kt

Taking dynamic input
@pragyajaiswa05l @afroz23
add kosaraju algorithm in cpp (jainaman224#2672)
5679f4f 
* add kosaraju algorithm in cpp

* Update kosaraju_algorithm.cpp
@j-shreya @afroz23
Aggressive cows (jainaman224#2543)
d1994ba 
* Create GENERIC_TREE_LOTRAVERSAL.java

* Update GENERIC_TREE_LOTRAVERSAL.java

* Revert "Update GENERIC_TREE_LOTRAVERSAL.java"

This reverts commit dfdd309.

* Revert "Create GENERIC_TREE_LOTRAVERSAL.java"

This reverts commit 2c87bbb.

* Create Aggressive_Cows.java

* Update Aggressive_Cows.java

1. Multi comments made
2. Extra spaces and lines removed
3. Indentation corrected
@shreyakapoor08 @afroz23
Logistic Regression in Python (jainaman224#2636)
537ef76
@Swarnimashukla @afroz23
Johnson Algorithm Implementation in Dart (jainaman224#2567)
1cb465d
AkanshaKamboj and others added 20 commits April 25, 2020 12:27
@AkanshaKamboj @afroz23
Linked list merge sort in C, C++, Java, Python jainaman224#1578 (jain…
ae98551 
…aman224#2395)

* Create Linked_List_Merge_Sort.c

* Add files via upload

* Update Linked_List_Merge_Sort.c

* Update Linked_List_Merge_Sort.c

* Update Linked_List_MergeSort.cpp

* Update Linked_List_MergeSort.java

* Update Linked_List_MergeSort.java

* Update Linked_List_MergeSort.py

* Update Linked_List_MergeSort.cpp

* Update Linked_List_MergeSort.java

* Update Linked_List_Merge_Sort.c

* Rename Linked_List_MergeSort.cpp to Linked_List_Merge_Sort.cpp

* Rename Linked_List_MergeSort.py to Linked_List_Merge_Sort.py

* Rename Linked_List_MergeSort.java to Linked_List_Merge_Sort.java
@afroz23
Chinese Remainder Theorem in Go (jainaman224#2675)
642f79e 
* Chinese Remainder Theorem in Go

* Added comments
@HariniJeyaraman @afroz23
1st commit (jainaman224#2605)
858de80
@Swarnimashukla @afroz23
Dijkstra Algorithm implementation in dart (jainaman224#2617)
2612ee8 
Update Dijkstra_Algorithm.dart
@lakshyajit165 @afroz23
added selection sort logic in typescript (jainaman224#2693)
4a5a5e4
@HardevKhandhar @afroz23
Tower Of Hanoi In Ruby (jainaman224#2701)
abb028e
@sandhyabhan @afroz23
Add Inorder Traversal in Kotlin (jainaman224#2657)
4a85c0e 
Updated inorder
@syedareehaquasar @afroz23
README FOR FORD FULKERSON METHOD (jainaman224#2589)
095d276
@kushagra-anand @afroz23
Kadane Algorithm (jainaman224#2534)
eb3b745 
* Create Kadane Algorithm in GO
@ravireddy07 @afroz23
Boyer Moore Algo in c added (jainaman224#2644)
959b2cd
@afroz23
Boyer Moore in Go (jainaman224#2687)
e50a7ac
@heisenbuggs @afroz23
Kruskal Algo in C (jainaman224#2255)
3f702f5
@HardevKhandhar @afroz23
Breadth First Search in Ruby (jainaman224#2635)
7f6c275 
* BFS in Ruby

* Updated Changes
@HardevKhandhar @afroz23
Tree Inorder Traversal In C# (jainaman224#2723)
914aaea
@RiaJha02 @afroz23
Adding Backtracking Using Bitmasking (jainaman224#2583)
ce02b5e 
Squashing Files
@raksha009 @afroz23
Transpose of matrix in java (jainaman224#2529)
e754eff 
changes made
@Manish-cloud @afroz23
Kruskal Algorithm Implementation in python (jainaman224#2682)
b24d034 
Used disjoint set data structure for Algorithm implementation.
@Rukmini-Meda @afroz23
squashing commit
8d5c048
@afroz23
Merge branch 'master' of https://github.com/afroz23/Algo_Ds_Notes
4655ecd
@afroz23
Revert "squashing commit"
f9be0eb 
This reverts commit 8d5c048.
singh-shreya6
singh-shreya6 requested changes Apr 25, 2020
View reviewed changes
Copy link
Collaborator

@singh-shreya6 singh-shreya6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your squashing has gone wrong. The files changed should be one. Also the number of commits in the second tab here should show as 1 after squashing. Now it shows 51. Please fix it.

Tree_Preorder_Traversal/Tree_Preorder_Traversal.js.js Outdated Show resolved Hide resolved
@singh-shreya6
Copy link
Collaborator

You are not squashing your commits, as you can see the number of commits have increased to 54, rather than decreasing to 1. If you are having trouble squashing, reach out to someone on slack or open a new PR

@afroz23 afroz23 closed this Apr 27, 2020
@afroz23 afroz23 reopened this Apr 27, 2020
@afroz23 afroz23 closed this Apr 27, 2020
@afroz23 afroz23 reopened this Apr 27, 2020
@afroz23 afroz23 closed this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singh-shreya6 singh-shreya6 singh-shreya6 requested changes

Assignees
No one assigned
Labels
easy GSSoC20
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree Preorder Traversal