Add a way of writing simple regression tests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Potentially I could list all .c files in |
This adds the simplest possible regression test to corrode which only runs a c file through gcc as well as corrode + rustc and then runs both applications checking that their exit status is the same.
Moves all logic except a thin wrapper out of the executable Main module and into the library itself which makes it possible for the test module to run corrode directly instead of going through an external process. (Running corrode as an external process does not work at all from the tests since there is no way of knowing where the corrode executable is placed).
I think this is the failing test but it is hard to be certain due to the interleaved output
… working Turns out that a missing return in the main function is only specified in c99.
|
Turns out that having main omit the return statement is only defined on c99 so I enabled c99 on the tests. I could perhaps just run the no-return-main under c99 but I am not aware of anything that needs to run under an older c version at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the simplest possible regression test to corrode which only runs a c file through gcc as well as corrode + rustc and then runs both applications checking that their exit status is the same.
Also made some tweaks to corrode-cc to make it work for me on windows (in git bash)