Skip to content

Commit

Permalink
Merge pull request #2223 from softins/macos-legacy
Browse files Browse the repository at this point in the history
Correct minimum macOS version for legacy install
  • Loading branch information
softins authored Jan 14, 2022
2 parents 5eec44f + 2c7f43c commit ccecafe
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 3 deletions.
6 changes: 5 additions & 1 deletion Jamulus.pro
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,11 @@ win32 {
MACOSX_BUNDLE_ICON.path = Contents/Resources
QMAKE_BUNDLE_DATA += MACOSX_BUNDLE_ICON
} else {
QMAKE_INFO_PLIST = mac/Info-make.plist
equals(QT_VERSION, "5.9.9") {
QMAKE_INFO_PLIST = mac/Info-make-legacy.plist
} else {
QMAKE_INFO_PLIST = mac/Info-make.plist
}
}

LIBS += -framework CoreFoundation \
Expand Down
41 changes: 41 additions & 0 deletions mac/Info-make-legacy.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>CFBundleName</key>
<string>@EXECUTABLE@</string>
<key>CFBundleDisplayName</key>
<string>@EXECUTABLE@</string>
<key>CFBundleIdentifier</key>
<string>@BUNDLEIDENTIFIER@</string>
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleVersion</key>
<string>@FULL_VERSION@</string>
<key>CFBundleShortVersionString</key>
<string>@SHORT_VERSION@</string>
<key>CFBundleSupportedPlatforms</key>
<array>
<string>MacOSX</string>
</array>
<key>LSApplicationCategoryType</key>
<string>public.app-category.music</string>
<key>LSMinimumSystemVersion</key>
<string>10.10</string>
<key>CFBundleExecutable</key>
<string>@EXECUTABLE@</string>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleIconFile</key>
<string>@ICON@</string>
<key>CFBundleGetInfoString</key>
<string>Jamulus - Created with QT</string>
<key>NSPrincipalClass</key>
<string>NSApplication</string>
<key>NSMicrophoneUsageDescription</key>
<string>Jamulus needs access to the microphone to record and stream your music to other musicians</string>
<!-- Temporarily opt out of Dark Mode as Qt 5.9 does not support it well, see https://bugreports.qt.io/browse/QTBUG-68891 -->
<key>NSRequiresAquaSystemAppearance</key>
<string>true</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion mac/Info-make.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>LSApplicationCategoryType</key>
<string>public.app-category.music</string>
<key>LSMinimumSystemVersion</key>
<string>10.13.0</string>
<string>${MACOSX_DEPLOYMENT_TARGET}</string>
<key>CFBundleExecutable</key>
<string>@EXECUTABLE@</string>
<key>CFBundleDevelopmentRegion</key>
Expand Down
2 changes: 1 addition & 1 deletion mac/Info-xcode.plist
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<key>LSApplicationCategoryType</key>
<string>public.app-category.music</string>
<key>LSMinimumSystemVersion</key>
<string>10.13.0</string>
<string>${MACOSX_DEPLOYMENT_TARGET}</string>
<key>CFBundleExecutable</key>
<string>${EXECUTABLE_NAME}</string>
<key>CFBundleDevelopmentRegion</key>
Expand Down

0 comments on commit ccecafe

Please sign in to comment.