Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump dev-drprasad/delete-tag-and-release from 0885ecc4123e071dd1a8be04d3a0578f5390581c to 8cd619d00037e4aeb781909c9a6b03940507d0da #3069

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2023

Bumps dev-drprasad/delete-tag-and-release from 0885ecc4123e071dd1a8be04d3a0578f5390581c to 8cd619d00037e4aeb781909c9a6b03940507d0da.

Commits
  • 8cd619d Merge pull request #35 from dev-drprasad/thadguidry-patch-1
  • fe70c9a Update README.md
  • 30b6d15 Update README.md
  • 7550ea1 Merge pull request #29 from wardellbagby/wardell/fix-tag-deletion
  • d416162 Fix issue where deleting tags failed
  • 488bcdd Merge pull request #31 from Sunny-25/emoji_change
  • f0585ac replaced pepper emoji with stop sign emoji
  • 94d338d Merge pull request #27 from wardellbagby/wardell/improve-dx
  • a7ff4c8 Update distributed bundle
  • afe0729 Add GitHub Workflows for Lint and Bundle check
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 15, 2023
@dependabot dependabot bot force-pushed the dependabot/github_actions/dev-drprasad/delete-tag-and-release-8cd619d00037e4aeb781909c9a6b03940507d0da branch from b137692 to a6d47a2 Compare May 19, 2023 21:17
@pljones
Copy link
Collaborator

pljones commented May 20, 2023

image
14 hours? I guess this isn't working still. Needs which PR?

@ann0see
Copy link
Member

ann0see commented May 20, 2023

Yes. The iOS hasn't been merged yet.

@ann0see
Copy link
Member

ann0see commented May 20, 2023

Ah yes. It needs #3065

Edit: Now merged.

Bumps [dev-drprasad/delete-tag-and-release](https://github.com/dev-drprasad/delete-tag-and-release) from 0885ecc4123e071dd1a8be04d3a0578f5390581c to 8cd619d00037e4aeb781909c9a6b03940507d0da.
- [Release notes](https://github.com/dev-drprasad/delete-tag-and-release/releases)
- [Commits](dev-drprasad/delete-tag-and-release@0885ecc...8cd619d)

---
updated-dependencies:
- dependency-name: dev-drprasad/delete-tag-and-release
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/dev-drprasad/delete-tag-and-release-8cd619d00037e4aeb781909c9a6b03940507d0da branch from a6d47a2 to 9588e2a Compare May 22, 2023 20:08
@ann0see ann0see added this to the Release 3.10.0 milestone May 22, 2023
@pljones
Copy link
Collaborator

pljones commented May 23, 2023

OK, so next question:

  • what is this and who can do due dilligence on the update?

@ann0see
Copy link
Member

ann0see commented May 23, 2023

This PR is updating an intermediate step for the release process. Basically it removes/updates releases (especially if they exist already as far as I remember). So we can test it by tagging a nightly.

@ann0see
Copy link
Member

ann0see commented May 23, 2023

@pljones
Copy link
Collaborator

pljones commented May 25, 2023

Looking at dev-drprasad/delete-tag-and-release@0885ecc...8cd619d it appears to be a big bump (0.2 to 1.0PR) with a lot of changes. The build looks okay from what I can see.

@ann0see
Copy link
Member

ann0see commented May 25, 2023

Also we should get rid of the github action which creates a release as it is unmaintained - probably we could move to the gh api or some other action.

@ann0see
Copy link
Member

ann0see commented May 25, 2023

As draft for that see: ann0see@b6fcbc4
I think this removes unneeded complexity.

@pljones
Copy link
Collaborator

pljones commented May 26, 2023

As draft for that see: ann0see@b6fcbc4 I think this removes unneeded complexity.

Mmm, maybe.

@ann0see
Copy link
Member

ann0see commented May 28, 2023

I'll open a PR with some more changes.

@pljones
Copy link
Collaborator

pljones commented Jun 11, 2023

Are we going to tell dependabot to "ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)"?

@ann0see
Copy link
Member

ann0see commented Jun 11, 2023

If we remove it dependabot will be silent for this, I hope. As my PR isn't in yet due to the two artifact upload ugliness this PR is still valid.

@ann0see
Copy link
Member

ann0see commented Jul 13, 2023

@dependabot rebase

@ann0see
Copy link
Member

ann0see commented Jul 13, 2023

Should close automatically

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 13, 2023

Looks like dev-drprasad/delete-tag-and-release is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Jul 13, 2023
@dependabot dependabot bot deleted the dependabot/github_actions/dev-drprasad/delete-tag-and-release-8cd619d00037e4aeb781909c9a6b03940507d0da branch July 13, 2023 21:06
@pljones pljones removed this from the Release 3.10.0 milestone Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants