Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mac Legacy from Qt 5.9.9 to 5.15.2 #3235

Merged
merged 1 commit into from
Jun 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/autobuild.yml
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ jobs:
- config_name: MacOS Legacy (artifacts+CodeQL)
target_os: macos
building_on_os: macos-12
base_command: QT_VERSION=5.9.9 SIGN_IF_POSSIBLE=0 ARTIFACT_SUFFIX=_legacy ./.github/autobuild/mac.sh
base_command: QT_VERSION=5.15.2 SIGN_IF_POSSIBLE=0 ARTIFACT_SUFFIX=_legacy ./.github/autobuild/mac.sh
# Enable CodeQL on mac legacy as this version does not get signed
run_codeql: true
# For Qt5 on Mac, we need to use an unsupported SDK version as macOS 12 doesn't
Expand Down
6 changes: 1 addition & 5 deletions Jamulus.pro
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,7 @@ win32 {
MACOSX_BUNDLE_ICON.path = Contents/Resources
QMAKE_BUNDLE_DATA += MACOSX_BUNDLE_ICON
} else {
equals(QT_VERSION, "5.9.9") {
QMAKE_INFO_PLIST = mac/Info-make-legacy.plist
} else {
QMAKE_INFO_PLIST = mac/Info-make.plist
}
QMAKE_INFO_PLIST = mac/Info-make.plist
}

LIBS += -framework CoreFoundation \
Expand Down
41 changes: 0 additions & 41 deletions mac/Info-make-legacy.plist

This file was deleted.