Add missing braces for clarity and clang (trivial) #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
approved these changes
Mar 28, 2024
pljones
reviewed
Mar 28, 2024
| @@ -901,6 +902,7 @@ void CServerSettings::ReadSettingsFromXML ( const QDomDocument& IniXMLDocument, | |||
| { | |||
There was a problem hiding this comment.
Should the else block at line 895 be enclosed in braces, too, for the sake of consistency?
There was a problem hiding this comment.
I wouldn't have thought so. We only need to solve the clang confusion due to the comments being between the else on 877 and the if belonging to it on 885.
pljones
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This is a trivial change to add a pair of braces to
CServerSettings::ReadSettingsFromXML()insettings.cpp, without changing the behaviour of the code.CHANGELOG: SKIP
Context: Fixes an issue?
Previously, due to the separation of
elseandifby comments,make clang_formatwas always getting confused and messing with the indentation.Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready to merge
What is missing until this pull request can be merged?
Review by eye and approval.
Checklist