Refactor macOS notarization and signing setup #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
force-pushed
the
autobuild/refactorMacNot
branch
from
f77aff3 to
0016342
Compare
4 tasks
|
Removes the need to merge #3263 |
pljones
reviewed
Aug 22, 2024
pljones
reviewed
Aug 22, 2024
pljones
reviewed
Aug 22, 2024
ann0see
force-pushed
the
autobuild/refactorMacNot
branch
from
0016342 to
2054bc4
Compare
ann0see
force-pushed
the
autobuild/refactorMacNot
branch
from
2054bc4 to
ccc56f5
Compare
ann0see
commented
Aug 22, 2024
| @@ -436,20 +437,6 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|
|||
| ## RELEASE PROCEDURE FOR: macOS App Store - storesigned pkg | |||
There was a problem hiding this comment.
Seems as if notarization is not needed for app store submission - at least it fails. Therefore, removing this.
ann0see
commented
Aug 22, 2024
| uses: BoundfoxStudios/action-xcode-staple@cd6c16fb6a3dfb365203a41343926f81e813afad | ||
| with: | ||
| product-path: deploy/${{ steps.get-artifacts.outputs.artifact_1 }} | ||
| run: ${{ matrix.config.base_command }} staple |
There was a problem hiding this comment.
Moved away from action for stapling since it's just two lines of code in the bash script.
softins
reviewed
Aug 22, 2024
softins
approved these changes
Aug 23, 2024
pljones
approved these changes
Aug 23, 2024
|
I've removed some unused actions from the whitelist at https://github.com/jamulussoftware/jamulus/settings/actions now e.g. the one for stapling. Please rebase all open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Gets rid of notarization action, streamlines autobuild and adds documentation to signing setup.
CHANGELOG: Autobuild: Use notarytool instead of action for macOS notarization
Context: Fixes an issue?
Supersedes: #3348
Does this change need documentation? What needs to be documented and how?
Includes documentation.
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Review
Checklist