Move reverb code out of utils #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softins
approved these changes
Oct 9, 2024
ann0see
commented
Oct 9, 2024
| Clear(); | ||
| } | ||
|
|
||
| bool CAudioReverb::isPrime ( const int number ) |
There was a problem hiding this comment.
Potentially Qt has a function for this. Not part of this PR though.
pljones
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
The reverb code is currently in utils. This should not be the case. For the future (if we replace the reverb with plugin compatibility), it makes sense to move the code into separate files
CHANGELOG: SKIP
Context: Fixes an issue?
No. Related to: https://github.com/orgs/jamulussoftware/discussions/3382#discussioncomment-10743921 to some extent also #3379
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Nothing.
Checklist