Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] update metadata/covers on kobo sync #3177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsheinen
Copy link

@tsheinen tsheinen commented Oct 6, 2024

I have initial support for updating metadata and covers on kobo sync. This is a draft and shouldn't be merged yet but I wanted to get a second pair of eyes on it.

I have a few specific things I'd like thoughts on.

  • Current design for handling hashed covers is bad/wrong when two books share the same cover. We could store thumbnails in sqlite or maybe store path to the cover on disk?
  • What does ChangedEntitlement do? It didn't seem to do anything in my testing.
  • How should we handle removing a book from KoboSyncedBooks when it changes? It's easy to just remove it when modified through the UI but ideally we should support filesystem changes too. Calibre's last_modified metadata column could be used but seems generally likely to be spuriously true. We could store last sync in KoboSyncedBooks and compare against last modified time on disk? Could also add an API route to resync a calibre id. Thoughts?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant