-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add github workflow for nitro node #424
Closed
InNoobWeTrust
wants to merge
7
commits into
janhq:main
from
InNoobWeTrust:feat/workflow-for-nitro-node
Closed
ci: Add github workflow for nitro node #424
InNoobWeTrust
wants to merge
7
commits into
janhq:main
from
InNoobWeTrust:feat/workflow-for-nitro-node
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commit" This reverts commit 1d79084.
InNoobWeTrust
changed the title
Add github workflow for nitro node
ci: Add github workflow for nitro node
Feb 27, 2024
InNoobWeTrust
commented
Feb 27, 2024
louis-menlo
reviewed
Feb 29, 2024
louis-menlo
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We are working on Cortex NPM and CLI so we could close this now. |
Great, I'm waiting for the official NPM package then. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a successor of #367