Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: :n file suffix doesn't scroll if browser (firefox) wasn't already open #196

Conversation

jannis-baum
Copy link
Owner

Close #193

@jannis-baum
Copy link
Owner Author

Hey @tuurep could you confirm that this fixes it? Turns out the bug made sense haha, it seems Firefox runs the web socket open event listener immediately while Chromium and Safari seem to finish the JS file first which is why the order didn't matter there. Or they're just slow. Anyways, for me it works like this on Firefox as well.

@jannis-baum jannis-baum requested a review from tuurep December 17, 2024 00:45
@tuurep
Copy link
Collaborator

tuurep commented Dec 19, 2024

Initial test:

On firefox (clean profile), this doesn't fix it for me

Also I noticed that firefox-developer-edition doesn't have this problem (even before this PR), but not sure how relevant this is :)

If the problem is in how fast the browser starts up, one thing I notice is that ff-dev-edition loads a little bit faster.

@jannis-baum
Copy link
Owner Author

I tried this out a bit again and I actually also still get the problem around 1/20 times. The other times it works. Can't figure out what causes it, it seems completely random.

Either way, this looks a lot like Firefox's fault to me now to be honest, especially since it's so inconsistent and works with other browsers. Not sure what else we could do other than introduce some random delay of sending the scroll message but that would worsen UX for everyone else so I'd rather not do it. Do you have another idea? Or do you know when we could expect Firefox to be upgraded to whatever the dev version is on now that fixes it?

@tuurep
Copy link
Collaborator

tuurep commented Dec 25, 2024

Hey, inspired by your 1/20 test on firefox, I tried the same on firefox developer edition and it can similarly happen randomly for me on firefox developer edition as well.

Yeah, I have no clue what to do about it but if something comes up I'll let you know.

@jannis-baum
Copy link
Owner Author

Since there doesn't seem to be anything we can do, let's merge & close this?

Copy link
Collaborator

@tuurep tuurep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sounds good

@tuurep tuurep merged commit 355ebb5 into main Jan 7, 2025
6 checks passed
@tuurep tuurep deleted the issue/193-bug-n-file-suffix-doesnt-scroll-if-browser-firefox-wasnt-already-open branch January 7, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: :n file suffix doesn't scroll if browser (firefox) wasn't already open
2 participants