Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper sorting on "Model Params" #124

Closed
Andrew-S-Rosen opened this issue Aug 18, 2024 · 1 comment
Closed

Improper sorting on "Model Params" #124

Andrew-S-Rosen opened this issue Aug 18, 2024 · 1 comment
Labels
bug Something isn't working site Website related

Comments

@Andrew-S-Rosen
Copy link

Sorting by model parameters doesn't sort correctly due to improper accounting for K vs. M.

image

@janosh
Copy link
Owner

janosh commented Aug 18, 2024

thanks for reporting! noticed that as well but neglected to open an issue for it.

just for later reference, needs to be fixed here svelte-zoo/src/lib/actions.ts.
started working on a fix last month in janosh/elementari#50 to turn numeric strings with metric suffixes back into floats, then thought might be smarter to save the unformatted value into HTML data attributes on each table cell and preferentially sort by that if found. unfortunately, other stuff got in the way of implementing that.

@janosh janosh added bug Something isn't working site Website related labels Aug 18, 2024
janosh added a commit that referenced this issue Aug 19, 2024
"training size" cols + bump [email protected]

closes Improper sorting on "Model Params" #124
@janosh janosh closed this as completed Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working site Website related
Projects
None yet
Development

No branches or pull requests

2 participants