Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortable action use data-sort-value HTML attributes for sorting when present #16

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

janosh
Copy link
Owner

@janosh janosh commented Aug 19, 2024

step 1 for addressing janosh/matbench-discovery#124. step 2 is to add data-sort-value to the MBD metrics table "training size" and "model params" columns

… provide data-sort-value HTML attribute for sorting

- Implement data-sort-value attribute support for more robust ordering
- Add get_html_sort_value function for recursive sort value extraction
- Introduce configurable CSS classes and styles for sorted headers
- Improve sorting logic to handle empty values and numeric comparisons
@janosh janosh merged commit 260bdbf into main Aug 19, 2024
3 checks passed
@janosh janosh deleted the sortable-use-data-sort-value branch August 19, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant