Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenID dependency to 2.0.1 #35

Open
aport opened this issue May 4, 2016 · 7 comments
Open

Update OpenID dependency to 2.0.1 #35

aport opened this issue May 4, 2016 · 7 comments

Comments

@aport
Copy link

aport commented May 4, 2016

passport-openid is broken on Node V6. Updating openid to v2.0.1 will fix this.

@ha1331
Copy link

ha1331 commented May 9, 2016

Would love if this was fixed sooner rather than later. Spent multiple hours (embarrassing amount of hours) figuring out why I wasn't able to get even the simplest of example codes run without crashing. Other than that, thanks for the the work you guys have done providing this software for the community.

@Martii
Copy link

Martii commented Jun 21, 2016

@jaredhanson
It would appear (confirmed we are in node 4.x too) that we might be encountering this issue in our production environment as well but not entirely sure here:

TypeError: params.hasOwnProperty is not a function
    at _checkSignatureUsingProvider (~/OpenUserJS.org/node_modules/openid/openid.js:1289:15)
    at _checkSignature (~/OpenUserJS.org/node_modules/openid/openid.js:1224:5)
    at _verifyAssertionAgainstProviders (~/OpenUserJS.org/node_modules/openid/openid.js:1188:12)
    at ~/OpenUserJS.org/node_modules/openid/openid.js:1153:7
    at ~/OpenUserJS.org/node_modules/openid/openid.js:686:7
    at ~/OpenUserJS.org/node_modules/openid/openid.js:541:11
    at done (~/OpenUserJS.org/node_modules/openid/openid.js:258:9)
    at IncomingMessage.<anonymous> (~/OpenUserJS.org/node_modules/openid/openid.js:262:32)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:934:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

Our deps at depth 0 that are still openid based and not oauth based, that we still currently use, are passport-steam (which seems to work with a test account although had one error on their end but a retry seems to have fixed that), passport-yahoo and passport-aol (these last two are your projects).

Please let us know if you need any additional intel and thanks in advance for the relook.

@johngeorgewright
Copy link

👍 Having the same issue.

@Poikilos
Copy link

@Noiwex there was no PR so I made one: #43

@rwky
Copy link

rwky commented Aug 16, 2018

Forked and fixed in https://github.com/passport-next/passport-openid

Install with npm install @passport-next/passport-openid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@Martii @rwky @johngeorgewright @Poikilos @ha1331 @aport and others