Add the ability to set custom fetch attributes as an option on the OpenID strategy #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 1, 2013 16:01
to allow specification of custom attributes through OpenID Attribute Exchange. Signed-off-by: Ben McIlwain <[email protected]>
…ct axschema.org parameters for retrieving profile data. Signed-off-by: Ben McIlwain <[email protected]>
Signed-off-by: Ben McIlwain <[email protected]>
Signed-off-by: Ben McIlwain <[email protected]>
Signed-off-by: Ben McIlwain <[email protected]>
|
@jaredhanson Is there any chance of getting this merged? We're running a private build of passport-openid with the patch applied at the moment, but it would be great to get proper support for arbitrary attributes. |
|
@CydeWeys can you please make a PR against https://github.com/passport-next/passport-openid and it'll get looked into. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new attribute "extensions" on the options object that is passed to the OpenID strategy upon initialization. This new attribute is a key/value pair of additional OpenID attributes (see the Attribute Exchange spec) that will be requested from the OpenID provider. The key is the URL of the attribute, e.g. "http://schema.openid.net/contact/email", and the value is either "required" or "optional", which instructs the OpenID provider on how to respond if it cannot deliver the information.