Implement proposal Improve authorization performance #1046

src/Application/Common/Behaviours/AuthorizationBehaviour.cs

@@ -41,7 +41,7 @@ public async Task<TResponse> Handle(TRequest request, RequestHandlerDelegate<TRe
                 {
                     foreach (var role in roles)
                     {
-                        var isInRole = await _identityService.IsInRoleAsync(_user.Id, role.Trim());
+                        var isInRole = _user.Roles?.Any(x => role == x)??false;
                         if (isInRole)
                         {
                             authorized = true;

src/Application/Common/Interfaces/IUser.cs

@@ -3,4 +3,6 @@
 public interface IUser
 {
     string? Id { get; }
+    List<string>? Roles { get; }
+
 }

src/Web/Services/CurrentUser.cs

@@ -14,4 +14,6 @@ public CurrentUser(IHttpContextAccessor httpContextAccessor)
     }
 
     public string? Id => _httpContextAccessor.HttpContext?.User?.FindFirstValue(ClaimTypes.NameIdentifier);
+    public List<string>? Roles => _httpContextAccessor.HttpContext?.User?.FindAll(ClaimTypes.Role).Select(x => x.Value).ToList();
+
 }

tests/Application.FunctionalTests/CustomWebApplicationFactory.cs

@@ -28,8 +28,13 @@ protected override void ConfigureWebHost(IWebHostBuilder builder)
         {
             services
                 .RemoveAll<IUser>()
-                .AddTransient(provider => Mock.Of<IUser>(s => s.Id == GetUserId()));
-
+                .AddTransient(provider =>
+                {
+                    var mock = new Mock<IUser>();
+                    mock.SetupGet(x => x.Roles).Returns(GetRoles());
+                    mock.SetupGet(x => x.Id).Returns(GetUserId());
+                    return mock.Object;
+                });
             services
                 .RemoveAll<DbContextOptions<ApplicationDbContext>>()
                 .AddDbContext<ApplicationDbContext>((sp, options) =>

tests/Application.FunctionalTests/Testing.cs

@@ -15,7 +15,7 @@ public partial class Testing
     private static CustomWebApplicationFactory _factory = null!;
     private static IServiceScopeFactory _scopeFactory = null!;
     private static string? _userId;
-
+    private static List<string>? _roles;
     [OneTimeSetUp]
     public async Task RunBeforeAnyTests()
     {
@@ -48,6 +48,11 @@ public static async Task SendAsync(IBaseRequest request)
     {
         return _userId;
     }
+
+    public static List<string>? GetRoles()
+    {
+        return _roles;
+    }
 
     public static async Task<string> RunAsDefaultUserAsync()
     {
@@ -84,7 +89,7 @@ public static async Task<string> RunAsUserAsync(string userName, string password
         if (result.Succeeded)
         {
             _userId = user.Id;
-
+            _roles = roles.ToList();
             return _userId;
         }