Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Style #174

Merged
merged 25 commits into from
Jun 8, 2023
Merged

Coding Style #174

merged 25 commits into from
Jun 8, 2023

Conversation

ImVietnam
Copy link
Contributor

No description provided.

1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ImVietnam
Copy link
Contributor Author

/done

@ImVietnam
Copy link
Contributor Author

/done

Copy link
Contributor

@henryonsoftware henryonsoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@ImVietnam
Copy link
Contributor Author

/done

Copy link
Contributor

@tunggnu tunggnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@tunggnu tunggnu merged commit 94a73bd into javascript-tutorial:master Jun 8, 2023
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants