Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it easier to build and debug on VS Code. #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ciscoheat
Copy link
Contributor

To make it easier to debug and build in VS Code. Makes it possible to debug just by pressing F5, and build with gradle using Ctrl+Shift+B.

@mbrowne
Copy link

mbrowne commented Feb 13, 2024

What was the concern again about merging this one? I thought the issue was not wanting to prioritize VS Code in the readme as if it were the primary IDE to be supported. But simply including these files to make it easier for those who are already using VS Code doesn't preclude the usage of other IDEs or potentially adding other integration files for other IDEs in the future.

@jcoplien
Copy link
Owner

jcoplien commented Feb 13, 2024 via email

@mbrowne
Copy link

mbrowne commented Feb 14, 2024

Hi Cope, thanks for the explanation. I realize that this is a research language not meant for production. I just want to make sure we're talking about the same thing...I looked at this PR, and literally all it does is give you this task menu (which can be activated with default VS Code keyboard shortcuts)—mainly useful for those who already happen to be using VS Code.

image

There is no need to detect if VS Code is present; if it's not being used, then the entire .vscode folder will simply be ignored. And I think this could potentially be useful for a large number of users—almost all the frontend web developers I know use VS Code now as their preferred IDE, and a lot of backend devs use it too. I would say though that it would mainly be useful to those who are interested in building the entire trygve project from source and perhaps tinkering with the source. For just running trygve code, I would agree that the built-in GUI is sufficient for research purposes.

So in summary, I understand what you're saying about their not being some huge advantage to including this PR, but I don't really follow what you're saying about the downsides. There seems to be little downside in including a feature that will be useful for some, and for the everyone else they will simply be unaware that it's there and it won't affect them at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants