Skip to content

Commit

Permalink
resubmit to cran round 3
Browse files Browse the repository at this point in the history
  • Loading branch information
João Santiago committed Mar 15, 2020
1 parent 6a4a955 commit 2ec7062
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 3 deletions.
4 changes: 2 additions & 2 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2020-03-01.
Once it is accepted, delete this file and tag the release (commit cd58832a7e).
This package was submitted to CRAN on 2020-03-15.
Once it is accepted, delete this file and tag the release (commit 6a4a955148).
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: sentryR
Type: Package
Title: Send Errors and Messages to Sentry
Title: Send Errors and Messages to 'Sentry'
Version: 1.1.0
Authors@R: c(
person("Joao", "Santiago", email = "[email protected]", role = c("aut", "cre")),
Expand Down
26 changes: 26 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,29 @@ This is my first CRAN submission.

Re-submitting because the Description field started with 'sentryR',
which is not allowed.

# Round 3
## Reviwer comments

2020-03-06 Swetlana Herbrandt

```
Thanks, please write package names, software names and API names in single quotes (e.g. 'Sentry') in Title and Description.
You are using installed.packages():
"This needs to read several files per installed package, which will be slow on Windows and on some network-mounted file systems.
It will be slow when thousands of packages are installed, so do not use it to find out if a named package is installed (use find.package or system.file) nor to find out if a package is usable (call requireNamespace or require and check the return value) nor to find details of a small number of packages (use packageDescription)."
[installed.packages() help page]
```

## Submission comments

2020-03-15

Thank you for the review, your comments are much appreciated it.

I have removed the usage of `installed.packages()` completely.
Instead, I instruct the user how to add that information at runtime if needed.

I also changed every instance of a package name, API or other piece of software
to include single quotes.

0 comments on commit 2ec7062

Please sign in to comment.