Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC 8 hiperlink support #364

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

houdini91
Copy link
Contributor

Fix handling of OSC 8 hyperlinks (e.g., \x1b]8;;url\x07label\x1b]8;;\x07) in escSeqParser.Consume

Add support for BEL (\x07)-terminated OSC sequences, which are used in hyperlinks (instead of the typical ESC )

Ensures that escape sequences are correctly parsed and excluded from visible text width calculations

Signed-off-by: houdini91 <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14018453830

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.872%

Changes Missing Coverage Covered Lines Changed/Added Lines %
text/escape_seq_parser.go 4 9 44.44%
Totals Coverage Status
Change from base Build 13608767539: -0.1%
Covered Lines: 3891
Relevant Lines: 3896

💛 - Coveralls

@jedib0t jedib0t merged commit 18e8a01 into jedib0t:main Mar 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants