Skip to content

Commit

Permalink
Apply openrewrite UpgradeToJava17
Browse files Browse the repository at this point in the history
  • Loading branch information
kirk-fitz committed Feb 2, 2025
1 parent e02c874 commit 6b8e142
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.quality.gates.sonar.api;

import static java.lang.String.format;
import static java.net.URLEncoder.encode;

import com.google.gson.GsonBuilder;
Expand Down Expand Up @@ -149,7 +148,7 @@ String getAPITaskInfo(JobConfigData configData, SonarInstance sonarInstance) thr
var sonarProjectTaskInfoPath = getSonarApiTaskInfoUrl();
var sonarHostUrl = sonarInstance.getUrl();
var taskInfoUri =
sonarHostUrl + format(sonarProjectTaskInfoPath, encode(sonarProjectKey, StandardCharsets.UTF_8));
sonarHostUrl + sonarProjectTaskInfoPath.formatted(encode(sonarProjectKey, StandardCharsets.UTF_8));
var request = new HttpGet(taskInfoUri);

return executeGetRequest(httpClient, request);
Expand All @@ -163,8 +162,8 @@ String getAPIInfo(JobConfigData configData, SonarInstance sonarInstance) throws
checkLogged(sonarInstance);

var sonarApiQualityGates =
sonarInstance.getUrl() + format(getSonarApiQualityGatesStatusUrl(), configData.getProjectKey());
var request = new HttpGet(format(sonarApiQualityGates, configData.getProjectKey()));
sonarInstance.getUrl() + getSonarApiQualityGatesStatusUrl().formatted(configData.getProjectKey());
var request = new HttpGet(sonarApiQualityGates.formatted(configData.getProjectKey()));

return executeGetRequest(httpClient, request);
}
Expand All @@ -175,7 +174,7 @@ protected String getComponentId(JobConfigData configData, SonarInstance sonarIns
checkLogged(sonarInstance);

var sonarApiQualityGates =
sonarInstance.getUrl() + format(getSonarApiComponentShow(), configData.getProjectKey());
sonarInstance.getUrl() + getSonarApiComponentShow().formatted(configData.getProjectKey());

Check warning on line 177 in src/main/java/org/quality/gates/sonar/api/SonarHttpRequester.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines

Lines 151-177 are not covered by tests
var request = new HttpGet(sonarApiQualityGates);
var result = executeGetRequest(httpClient, request);
var gson = new GsonBuilder().create();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,12 @@ public void testCreateJSONArrayFromStringWhenStringNotInJSONFormatShouldThrowQGE
@Test(expected = QGException.class)
public void testCreateJSONArrayFromStringThrowsExceptionWhenStringISAJSONObjectShouldThrowQGException() {
qualityGateResponseParser.createJSONArrayFromString(
"{\n" + "err_code: 404,\n" + "err_msg: \"Resource not found: wrongProjectKey\"\n" + "}");
"""
{
err_code: 404,
err_msg: "Resource not found: wrongProjectKey"
}\
""");
}

@Test
Expand Down

0 comments on commit 6b8e142

Please sign in to comment.