Require Java 11 and Jenkins 2.361.4 or newer #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
changed the title
https://www.jenkins.io/doc/developer/publishing/documentation/ describes the process to change from wiki based plugin documentation to host the plugin documentation in GitHub. In this case, the preferred plugin documentation location seems to be the bitbar.com site. Will adjust the README to first include a link to the bitbar.com site while retaining the other information in the README.
Guava in Jenkins is now running very recent versions. No need to package Guava in this plugin. Java 11 is the minimum Java version since Jenkins 2.361.1. no need to declare it. Tool versions are all current and remain updated.
MarkEWaite
force-pushed
the
use-github-for-plugins-jenkins-io-docs
branch
from
8d9b8d0 to
70f8db3
Compare
MarkEWaite
changed the title
MarkEWaite
changed the title
The plugin already requires Java 11. Jenkins 2.361.1 is the first long term support release that requires Java 11. https://www.jenkins.io/blog/2022/06/28/require-java-11/ announced that change in June 2022. https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ recommends choosing the terminal release (2.361.4) rather than choosing the initial release in an LTS baseline, so 2.361.4 was chosen instead of 2.361.1. https://stats.jenkins.io/pluginversions/testdroid-run-in-cloud.html shows that users of this plugin running Jenkins versions that require Java 11 (2.357 weekly or newer, 2.361.1 LTS or newer) are already running Jenkins 2.375.2 or newer. This change does not create any barrier for their upgrade to a release based on this change. They are already running a newer version than the minimum Jenkins version required by this change. Declares dependency on several Jenkins API plugins for testdroid-api rather than relying on Maven to bundle the transitive dependencies. This reduces the size of the plugin hpi file and allows Jenkins users to run with the more recent API version rather than requiring a new release of this plugin. Earlier changes in this pull request removed the bundling of guava since a modern guava version is provided with Jenkins core. Those dependency changes have reduced the plugin hpi file from over 10 MB to less than 5 MB.
MarkEWaite
changed the title
|
@arturCwiklinsky this pull request simplifies the maintenance of plugin dependencies and reduces the number of dependencies that are bundled into the plugin. |
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require Jenkins 2.361.4 or newer, use plugin bill of materials
See the "Improve a plugin" tutorials for the videos that describe the rationale behind those changes.
Removes the need for the following two pull requests: