-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fixed typos, some refactoring #15344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for jestjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -108,7 +108,7 @@ const resolveConfigPathByTraversing = ( | |||
throw new ValidationError(...makeMultipleConfigsErrorMessage(configFiles)); | |||
} | |||
|
|||
if (configFiles.length > 0 || packageJson) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packageJson checked earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we don't need the ??
in the body either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we don't need the
??
in the body either
Yes, thanks, corrected
old var code changed to let as it is recommended to use let or const
some typos fix
Co-authored-by: Simen Bekkhus <[email protected]>
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Mind signing the CLA? |
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
1 similar comment
This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one. |
Summary
Test plan