Internal API - Visibility System support #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
sverdlov93
reviewed
Dec 20, 2024
jfconnect/services/metrics.go
Outdated
| return *js.serviceDetails | ||
| } | ||
|
|
||
| func (js *JfConnectService) LogMetric(metric []byte) error { |
There was a problem hiding this comment.
metric has no type? just simple []byte?
There was a problem hiding this comment.
Yes, it's just a JSON payload added to the post request.
Adding an additional type to that payload would add an unnecessary complication to the flow in my opinion.
Co-authored-by: Michael Sverdlov <[email protected]>
eyalbe4
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an internal API, in the JFrog Platform, to allow for usage reporting for servies that rely on this library.