Make "Sign up" & "Sign in" similar w/ login links #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `login link style` is "normal" with a wide screen, the login links are styled differently: one as a plain, unmarked link, and one as a button. This change makes the links consistent on narrow screens and on wide screens: either both links on narrow screens (in the dropdown) or both buttons on wider screens. Additionally fixed an issue where there would be no login URL using login link style and not allowing registration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
login link styleis "normal" with a wide screen, the login links are styled differently: one as a plain, unmarked link, and one as a button. Screen shot of vanilla docassemble below:While the aesthetic isn't bad, the usability suffers, as it's not clear either at a glace or when hovering, that "Sign up" is a clickable link. This gets worse when modifying the bootstrap theme (see mplp/docassemble-mlhframework#87 for this original discussion, where it's more pronounced using our modified nav bar color).
This change makes the links consistent on narrow screens and on wide screens: either both links on narrow screens (in the dropdown) or both buttons on wider screens.
Additionally fixed an issue where there would be no login URL using login link style and not allowing registration.
Tested with
login link style == "normal", and withallow registrationas true and false.