Feature: Add cuboids_from_id functionality #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movestill
reviewed
May 16, 2021
movestill
requested changes
Jun 6, 2021
|
ready for merge pending approval! |
movestill
approved these changes
Aug 9, 2022
|
@dxenes1 It still says draft PR, that isn't get case correct? It also looks like one of the circleci tests have failed. |
sandyhider
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For applications in proofreading and meshing it's useful to have a way to get the cuboids that specifically belong to one ID. This functionality existed as an intermediate product of indexing and bounding boxes, so I just yanked some of that code to create a
cuboid_from_id()function that returns the list of cuboid corners that contain a particular ID.Essentially the function lives in the
object_ind.pyfunction and its inputs are a BossResource, resolution, and ID. It returns a dict object with a single fixed keyword,cuboidsand the value is a list of tuples containing cuboid corners in X,Y,Z format.EDIT:
Output are now cuboid bounds in XYZ, making it easier to pass the output dictionary object directly into
get_cutout()requests in intern.boss PR: jhuapl-boss/boss#78